Haproxy route policy switch default db to postgresql by Thanhphan1147 · Pull Request #413 · canonical/haproxy-operator

Thanhphan1147 · 2026-03-26T15:34:04Z

Switch the default db engine of the policy app to postgresql.
Added psycopg-binary as a dependency

Checklist

The charm style guide was applied
The contributing guide was applied
The changes are compliant with ISD054 - Managing Charm Complexity
The documentation is updated
A change artifact was added for user-relevant changes in docs/release-notes/artifacts. If this PR does not require a change artifact, the PR has been tagged with no-release-note.
The PR is tagged with appropriate label (urgent, trivial, complex)
The changelog is updated with user-relevant changes in the format of keep a changelog v1.1.0

…al/haproxy-operator into haprox-route-policy-requests-api

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…al/haproxy-operator into haprox-route-policy-requests-api

…rules-matching

…ests for auth

seb4stien · 2026-03-26T16:38:34Z

haproxy-route-policy/haproxy_route_policy/settings.py

-        "NAME": BASE_DIR / "db.sqlite3",
-    }
+        "ENGINE": "django.db.backends.postgresql",
+        "PASSWORD": os.getenv("DJANGO_DATABASE_PASSWORD", ""),


Shouldn't it refuste to start without a password? What are the consequences of having PASSWORD as an empty string?

I guess this would be useful in testing if we allow connecting to the DB without a password

If we have a DB connection issue it'll be wrapped in a 500 HTTP error message using the middleware that we defined

No db should be configured with no password, even in dev ;)
If we want to have a default value here, I'd use a generic one: "postgres" for instance.

seb4stien

Not sure about the default value for password.

github-actions · 2026-03-26T18:52:42Z

Test results for commit `2b15ad8`

Test coverage for 2b15ad8

Name                                       Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------------------------------
lib/charms/haproxy/v0/ddos_protection.py     154     51     34      8    64%   157-174, 183-187, 288, 316-318, 323, 326-330, 342-344, 381, 387, 393, 396, 424, 495-498, 510-529
src/charm.py                                  21      0      0      0   100%
src/state.py                                  43      0      0      0   100%
--------------------------------------------------------------------------------------
TOTAL                                        218     51     34      8    73%

Static code analysis report

Run started:2026-03-26 16:41:50.034766+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 333
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2026-03-26T18:52:43Z

Test results for commit `2b15ad8`

Test coverage for 2b15ad8

Name                                         Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------------------------
lib/charms/haproxy/v0/ddos_protection.py       154     42     34      3    72%   157-174, 183-187, 265, 284, 415-418, 422-424, 459-478, 514-529
lib/charms/haproxy/v0/spoe_auth.py             158     55     32      2    59%   203, 304-306, 315, 354-381, 392-402, 441-442, 459-472, 484-501, 522-525, 529-531
lib/charms/haproxy/v1/haproxy_route_tcp.py     385    153     78      8    56%   209, 212, 281, 290-293, 297-300, 318-321, 336, 342-347, 447, 452, 829-832, 836, 863-874, 897-900, 904-906, 926-928, 1042-1083, 1087-1093, 1097, 1166-1195, 1266-1305, 1335-1337, 1362-1364, 1386-1390, 1409-1411, 1429-1431, 1438-1444, 1452-1454, 1462-1463, 1474-1481, 1494-1505, 1513-1534, 1546-1547, 1558-1559, 1570-1573, 1584-1585, 1614-1623, 1639-1642, 1658-1669, 1685-1688, 1706-1717, 1728-1729, 1737-1738, 1746-1747, 1758-1761
lib/charms/haproxy/v2/haproxy_route.py         385     53     98     26    82%   181, 257, 266-269, 294-297, 318-323, 673-674, 860->exit, 867, 893-904, 927-930, 934-936, 955-957, 1129-1135, 1139, 1336->1338, 1340->1342, 1342->1344, 1344->1346, 1346->1348, 1348->1351, 1386, 1394, 1399, 1402, 1427, 1455, 1459, 1463, 1486, 1506, 1515-1516, 1518->exit, 1554-1556, 1576, 1590, 1595-1597
src/charm.py                                   286     69     78     11    71%   100, 228, 236-252, 257, 262, 279, 290, 296-297, 331-351, 455-463, 491-504, 517-522, 531, 544-545, 552, 562, 572, 578-584, 600, 650-653, 659->658, 672-675
src/haproxy.py                                 127     31      6      2    75%   110-116, 136-158, 268-269, 272, 280-286, 314, 344-355, 367-369, 379-380
src/http_interface.py                           73     25      4      0    62%   74, 83, 92, 106-108, 126, 138, 150, 162, 170-175, 187, 194, 202, 217-227
src/state/charm_state.py                        77     15     14      4    79%   93-95, 100-101, 104, 145-150, 159, 208-210, 222-223
src/state/ddos_protection.py                    39      0      2      0   100%
src/state/exception.py                           1      0      0      0   100%
src/state/ha.py                                 30      1      2      1    94%   50
src/state/haproxy_route.py                     197     14     60      5    90%   132, 161-170, 194, 227, 297, 346-348, 365
src/state/haproxy_route_tcp.py                 120     17     42      1    80%   92-94, 109->112, 147-160
src/state/ingress.py                            38      0      4      0   100%
src/state/ingress_per_unit.py                   32      0      4      0   100%
src/state/spoe_auth.py                          26      2      2      0    93%   63-64
src/state/tls.py                                39      7     12      4    78%   74, 77-78, 127-135, 141-142
src/state/validation.py                         46     23      8      1    44%   66-67, 71-98
src/tls_relation.py                             61      3     14      3    92%   86->85, 118-128, 140->142
----------------------------------------------------------------------------------------
TOTAL                                         2274    510    494     71    74%

Static code analysis report

Working... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00
Run started:2026-03-26 16:54:35.187328+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 10203
  Total lines skipped (#nosec): 13
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 10

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2026-03-26T18:52:43Z

Test results for commit `2b15ad8`

Test coverage for 2b15ad8

Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
haproxy_route_policy/__init__.py            0      0   100%
haproxy_route_policy/settings.py           29      1    97%
haproxy_route_policy/test_settings.py       4      0   100%
haproxy_route_policy/urls.py                5      0   100%
manage.py                                  11      2    82%
policy/__init__.py                          0      0   100%
policy/apps.py                              3      0   100%
policy/db_models.py                        49      2    96%
policy/middleware.py                       16      4    75%
policy/migrations/0001_initial.py           7      0   100%
policy/migrations/0002_rule.py              5      0   100%
policy/migrations/__init__.py               0      0   100%
policy/rule_engine.py                      36      1    97%
policy/serializers.py                      25      0   100%
policy/tests/__init__.py                    0      0   100%
policy/tests/test_auth.py                  36     20    44%
policy/tests/test_models.py                85      0   100%
policy/tests/test_rule_engine.py          117      0   100%
policy/tests/test_views.py                201      0   100%
policy/urls.py                              3      0   100%
policy/views.py                            83      6    93%
-----------------------------------------------------------
TOTAL                                     715     36    95%

Static code analysis report

Run started:2026-03-26 16:07:06.042367+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1556
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2026-03-26T18:52:44Z

Test results for commit `2b15ad8`

Test coverage for 2b15ad8

Name                               Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------------------------
src/charm.py                          45      9      2      0    77%   65-91, 96-98
src/haproxy_spoe_auth_service.py      44     16      2      0    61%   56-64, 76-82, 93-117
src/state.py                          55     15      6      1    67%   64-66, 79, 125-146
------------------------------------------------------------------------------
TOTAL                                144     40     10      1    68%

Static code analysis report

Run started:2026-03-26 16:41:41.727319

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 409
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 1

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

…switch-default-db-to-postgresql

Thanhphan1147 and others added 30 commits March 17, 2026 15:08

Implement request API

7b7a688

update model validation before save and add unit tests

00a3ea7

Merge branch 'main' into haprox-route-policy-requests-api

77622dd

use environment variables for secret key

bc11a1f

Merge branch 'haprox-route-policy-requests-api' of github.com:canonic…

6f1499d

…al/haproxy-operator into haprox-route-policy-requests-api

ruff format

6e98d08

add secret key for testing

f073454

remove port attribute from test

4842e4a

add requirements.txt for testing

5b667c0

reintroduce port field

e719d33

Add change artifact

597eb66

run lint with uv

6f51301

add unit testing

7f245ea

remove custom test

6254485

update migration

ad50aa3

Wrap creation under transaction.atomic

3640143

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

adbf18f

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

remove unused code

daef5d3

minor fixes to settings

78e5dc0

Potential fix for pull request finding

cd93076

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

use django serializer

f93e9cb

update gitignore

4a92e21

Merge branch 'haprox-route-policy-requests-api' of github.com:canonic…

7b1c9ca

…al/haproxy-operator into haprox-route-policy-requests-api

update view to use django rest

22e4aef

remove python-version

266e20e

update gitignore

d5db748

add missing license headers

34ca372

Add rules engine

3ea5d0e

update migration

16833e4

update view

efe9beb

Thanhphan1147 added 13 commits March 25, 2026 13:30

add change artifact

c564054

update imports

92e6810

update naming

ed16de9

update rules matching logic

d3b5e6d

update tests

ec6d312

save request using serializer with the correct instace

93ce0f4

Merge remote-tracking branch 'origin/main' into haproxy-route-policy-…

7172da3

…rules-matching

group tests

3e3a0a9

update formatting

60cc53f

Add authentication configuration for django-restframework and adapt t…

195fa28

…ests for auth

add change artifact

75663fa

Add token urls

3e6bee2

switch DB engine to postgres

7eb5cb8

Thanhphan1147 requested a review from a team as a code owner March 26, 2026 15:34

Thanhphan1147 added the trivial label Mar 26, 2026

add change artifact

2b15ad8

github-actions bot added the Libraries: Out of sync label Mar 26, 2026

arturo-seijas approved these changes Mar 26, 2026

View reviewed changes

seb4stien reviewed Mar 26, 2026

View reviewed changes

Base automatically changed from haproxy_route_policy_add_authentication to main March 30, 2026 14:34

Merge remote-tracking branch 'origin/main' into haproxy-route-policy-…

73de689

…switch-default-db-to-postgresql

Thanhphan1147 requested a review from seb4stien March 30, 2026 16:07

seb4stien approved these changes Mar 30, 2026

View reviewed changes

github-actions bot added Libraries: OK and removed Libraries: Out of sync labels Mar 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Haproxy route policy switch default db to postgresql#413

Haproxy route policy switch default db to postgresql#413
Thanhphan1147 wants to merge 90 commits intomainfrom
haproxy-route-policy-switch-default-db-to-postgresql

Thanhphan1147 commented Mar 26, 2026 •

edited

Loading

Uh oh!

seb4stien Mar 26, 2026

Uh oh!

Thanhphan1147 Mar 30, 2026 •

edited

Loading

Uh oh!

Thanhphan1147 Mar 30, 2026

Uh oh!

seb4stien Mar 30, 2026

Uh oh!

seb4stien left a comment

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Thanhphan1147 commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

seb4stien Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Thanhphan1147 Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Thanhphan1147 Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

seb4stien Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

seb4stien left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 26, 2026

Test results for commit 2b15ad8

Uh oh!

github-actions bot commented Mar 26, 2026

Test results for commit 2b15ad8

Uh oh!

github-actions bot commented Mar 26, 2026

Test results for commit 2b15ad8

Uh oh!

github-actions bot commented Mar 26, 2026

Test results for commit 2b15ad8

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Thanhphan1147 commented Mar 26, 2026 •

edited

Loading

Thanhphan1147 Mar 30, 2026 •

edited

Loading

Test results for commit `2b15ad8`

Test results for commit `2b15ad8`

Test results for commit `2b15ad8`

Test results for commit `2b15ad8`